Discriminate log messages by session ID #10961
Open
+270
−139
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
E2E Tests 🚀 |
jmcphers
previously approved these changes
Dec 5, 2025
extensions/positron-r/src/lsp.ts
Outdated
| * all LSP sessions. Watch out for session start log messages to find the | ||
| * relevant section of the log. | ||
| */ | ||
| const LSP_OUTPUT_CHANNEL = positron.window.createRawLogOutputChannel('R Language Server'); |
Collaborator
There was a problem hiding this comment.
Nit: this makes the output channel open very early and it'll be around even for Python-only users. Not a big deal.
Since there is only one session active at a time
lionel-
force-pushed
the
task/log-session
branch
from
eb89833 to
97bc21b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Branched from #10933
Progress towards #10121
This PR:
Makes the kernel logs less confusing when multiple sessions are running concurrently. This should help making sense of CI logs for Ark - Extensions tests unstable due to LSP session issues #10121.
Reduces the number of output channels, making it easier for users to find and report the relevant channels.
Approach:
Kernelchannel, oneSupervisorchannel, and oneLanguage Serverchannel for all sessions, console or notebook.notebookparticle for notebooks).This is going to make logs more busy but will greatly improve disambiguation in debugging session. The "Filter" feature of output channels can also be used to filter messages for a particular session, if needed.
The alternative approach I first considered was to include the session ID in output channel names. The issue is that this leads to an explosion of output channels (3 by session ID) that are never cleaned up.
If we go forward with this, I'll send a companion PR to update https://positron.posit.co/troubleshooting.html#python-and-r-logs.
Here is how this looks:
Screen.Recording.2025-12-05.at.10.22.27.mov
Screen.Recording.2025-12-05.at.10.23.01.mov
Screen.Recording.2025-12-05.at.10.23.41.mov
Release Notes
New Features
Kernel,Supervisor, andLanguage Serverchannel per language.Bug Fixes
QA Notes